Allow pre-parsing of ESI document, add example of fetching per-user fragment variants #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t URLs per-request
vagetman
reviewed
Oct 23, 2024
| @@ -140,9 +169,8 @@ impl Processor { | |||
| ); | |||
|
|
|||
| // `root_task` is the root task that will be used to fetch tags in recursive manner | |||
| let root_task = &mut Task::new(); | |||
| let root_task: &mut Task = &mut Task::new(); | |||
There was a problem hiding this comment.
I think this is pretty obvious and no more explicit notation required.
| # This file describes a Fastly Compute package. To learn more visit: | ||
| # https://developer.fastly.com/reference/fastly-toml/ | ||
|
|
||
| authors = ["kailan@enviark.com"] |
There was a problem hiding this comment.
Suggested change
| authors = ["kailan@enviark.com"] | |
| authors = ["kblanks@fastly.com"] |
I think we usually leaving those empty or with fastly emails, no?
Comment on lines
+1
to
+4
| use std::{ | ||
| collections::{HashMap, VecDeque}, | ||
| io::Write, | ||
| }; |
There was a problem hiding this comment.
No need to use VecDeque
Suggested change
| use std::{ | |
| collections::{HashMap, VecDeque}, | |
| io::Write, | |
| }; | |
| use std::{collections::HashMap, io::Write}; | |
| }; |
| let mut xml_writer = Writer::new(output_writer); | ||
|
|
||
| // Parse the ESI document and store it in memory | ||
| let mut events = VecDeque::new(); |
There was a problem hiding this comment.
No need to use VecDeque
Suggested change
| let mut events = VecDeque::new(); | |
| let mut events = Vec::new(); |
| let mut events = VecDeque::new(); | ||
| let mut beresp_reader = Reader::from_reader(beresp.take_body()); | ||
| parse_tags("esi", &mut beresp_reader, &mut |event| { | ||
| events.push_back(event); |
There was a problem hiding this comment.
No need to use VecDeque
Suggested change
| events.push_back(event); | |
| events.push(event); |
|
|
||
| // Process the already-parsed ESI document, replacing the request URLs with the variant URLs | ||
| let result = processor.process_parsed_document( | ||
| events, |
There was a problem hiding this comment.
No need to use VecDeque
Suggested change
| events, | |
| events.into(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3