Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add take_events() function (hacktoberfest-accepted) #392

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

nguyentritai2906
Copy link
Contributor

Description

This PR is from robinhood/faust adds a new function stream.take_events() which will return events()

@wbarnha
Copy link
Member

wbarnha commented Oct 24, 2022

Nice catch, this should hopefully close a lot of ongoing bugs.

@wbarnha
Copy link
Member

wbarnha commented Oct 24, 2022

Looks like the code needs to be linted.

Copy link
Member

@wbarnha wbarnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't break any features and adds functionality, so I consider this a definite approve. LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Base: 94.45% // Head: 94.03% // Decreases project coverage by -0.41% ⚠️

Coverage data is based on head (9dd4ab9) compared to base (ecee01b).
Patch coverage: 2.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   94.45%   94.03%   -0.42%     
==========================================
  Files         102      102              
  Lines       11023    11073      +50     
  Branches     1293     1297       +4     
==========================================
+ Hits        10412    10413       +1     
- Misses        533      582      +49     
  Partials       78       78              
Impacted Files Coverage Δ
faust/streams.py 88.01% <2.00%> (-8.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wbarnha wbarnha merged commit 94ff38f into faust-streaming:master Oct 24, 2022
@wbarnha wbarnha changed the title Add take_events() function Add take_events() function (hacktoberfest-accepted) Oct 26, 2022
@wbarnha wbarnha mentioned this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants