Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix using Shift to select results in clearing selected text #168

Merged
merged 2 commits into from
Jul 4, 2024
Merged

fix using Shift to select results in clearing selected text #168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b47e9ff
fix using Shift to select results in clearing selected text
eagleoflqj Jul 3, 2024
48f2595
comment [skip ci]
eagleoflqj Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion macosfrontend/macosfrontend.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ public func commitAndSetPreeditSync(
// Without client preedit, Backspace bypasses IM in Terminal, every key
// is both processed by IM and passed to client in iTerm, so we force a
// dummy client preedit here.
if preedit.isEmpty && dummyPreedit {
// Some apps also need it to get accurate cursor position to place candidate window.
// But when there is selected text, we don't want the dummy preedit to clear all of
// them. An example is using Shift+click to select but IM switch happens.
if preedit.isEmpty && dummyPreedit && client.selectedRange().length == 0 {
setPreedit(client, " ", 0)
} else {
setPreedit(client, preedit, cursorPos)
Expand Down