Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable in BacktrackingLineSearch class #10

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Remove unused variable in BacktrackingLineSearch class #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@ endif()
if(UNGAR_INSTALL)
include(GNUInstallDirs)

# Install library headers.
# Install Ungar headers.
install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})

# Install library binaries.
# Install Ungar binaries.
install(
TARGETS ungar
EXPORT ${PROJECT_NAME}Targets
Expand All @@ -150,7 +150,7 @@ if(UNGAR_INSTALL)
INCLUDES
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})

# Install library configuration files.
# Install Ungar configuration files.
include(CMakePackageConfigHelpers)

configure_package_config_file(
Expand Down
3 changes: 1 addition & 2 deletions include/ungar/optimization/backtracking_line_search.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,7 @@ class BacktrackingLineSearch {
const Eigen::MatrixBase<_SearchDirection>& dw,
const Concepts::CostFunction<_W> auto& costFunction,
const Concepts::ConstraintViolation<_W> auto& constraintViolation,
Eigen::MatrixBase<_W> const& w,
const bool verbose = false) const {
Eigen::MatrixBase<_W> const& w) const {
UNGAR_ASSERT(costFunctionGradient.cols() == 1_idx);
UNGAR_ASSERT(dw.cols() == 1_idx);
UNGAR_ASSERT(costFunctionGradient.rows() == dw.rows());
Expand Down