addpatch: electron33 33.0.0-1 #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes at riscv-forks/electron: Update patchset for electron33(chromium 130): riscv-forks/electron@c7dff70 Packaging changes compared to electron 32: Use native rollup instead of wasm rollup, to workaround wasm errors like: RuntimeError: Command '/build/electron33/src/src/third_party/node/linux/node-linux-x64/bin/node /build/electron33/src/src/third_party/node/node_modules/@rollup/wasm-node/dist/bin/rollup /build/electron33/src/src/out/Release/gen/third_pa rty/lit/v3_0/lit.js --format esm --dir /build/electron33/src/src/out/Release/gen/third_party/lit/v3_0/bundled --entryFileNames [name].rollup.js --sourcemap --sourcemapExcludeSources --config ../../third_party/lit/v3_0/rollup.config.mjs' failed /build/electron33/src/src/out/Release/gen/third_party/lit/v3_0/lit.js → gen/third_party/lit/v3_0/bundled... [!] RuntimeError: unreachable at null.<anonymous> (wasm://wasm/005abe4a:1:1224394) at null.<anonymous> (wasm://wasm/005abe4a:1:1353214) at null.<anonymous> (wasm://wasm/005abe4a:1:998801) at null.<anonymous> (wasm://wasm/005abe4a:1:95196) at null.<anonymous> (wasm://wasm/005abe4a:1:93978) at null.<anonymous> (wasm://wasm/005abe4a:1:1037939) at null.<anonymous> (wasm://wasm/005abe4a:1:93359) at null.<anonymous> (wasm://wasm/005abe4a:1:91561) at null.<anonymous> (wasm://wasm/005abe4a:1:93978) at null.<anonymous> (wasm://wasm/005abe4a:1:218801) I am not familiar with wasm debugging. Not sure if it is a v8 bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes at riscv-forks/electron:
Update patchset for electron33(chromium 130):
riscv-forks/electron@c7dff70
Packaging changes compared to electron 32:
Use native rollup instead of wasm rollup, to workaround wasm errors like:
I am not familiar with wasm debugging. Not sure if it is a v8 bug.