Add missing dependency on syntax_tools #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will debug the CI tests in #112 and a rebase later should make sure tests still pass. |
|
a rebase should fix the CI. |
|
More recent versions of Dialyer would catch this as unknown, right? |
The `recon:source/1` function calls `erl_prettypr` from `syntax_tools` application. This dependency was missing from the `.app` - this resulting in incomplete builds in some cases
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
recon:source/1function callserl_prettyprfromsyntax_toolsapplication. This dependency was missing from the.app- this resulting in incomplete builds in some cases