Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of tagging using sphinx-tags #26

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

rekomodo
Copy link
Collaborator

Added sphinx-tags to the build requirements.

Had to supress warnings from Jupyter Book's external-toc extension from using external toctrees due to sphinx-tags generating some for the tag pages.
The supression looks like

sphinx:
  config:
    suppress_warnings: ["etoc.toctree"]

from this issue and is present in the book's config.

Resolves #23 .

@rekomodo
Copy link
Collaborator Author

I think it looks great, we might want to change the section's title though.

@RemDelaporteMathurin
Copy link
Contributor

I was able to compile locally but in RTD there seems to be a couple of warnings still.

Would it be possible to have the tags not above the title? Like here for instance?

Also, I see we can colour the tags instead of having them plain. It looks a bit sexier!

@RemDelaporteMathurin RemDelaporteMathurin merged commit 41ab232 into festim-dev:main Jun 19, 2024
1 check passed
@rekomodo rekomodo deleted the tagging branch June 27, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tagging system
2 participants