-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme fetch integration docs #10
Conversation
@@ -17,7 +17,7 @@ contract PriceContract is UsingFetch { | |||
constructor(address payable _fetchAddress) UsingFetch(_fetchAddress) {} | |||
|
|||
function getPrice() public view returns (uint256) { | |||
bytes32 _plsQueryId = keccak256(abi.encode("SpotPrice", abi.encode("pls", "usd"))); | |||
bytes32 _plsQueryId = keccak256(abi.encode("SpotPrice", abi.encode("llpls", "usd"))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llpls
@@ -31,9 +31,8 @@ contract PriceContract is UsingFetch { | |||
|
|||
Find Fetch contract addresses: | |||
|
|||
mainnet: 0x6f390b99201bb43A05757019efe9C99651e04584 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainnet: 0x6f390b99201bb43A05757019efe9C99651e04584
@@ -31,9 +31,8 @@ contract PriceContract is UsingFetch { | |||
|
|||
Find Fetch contract addresses: | |||
|
|||
mainnet: 0x6f390b99201bb43A05757019efe9C99651e04584 | |||
testnet: 0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testnet: 0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb
mainnet: 0x6f390b99201bb43A05757019efe9C99651e04584 | ||
testnet: 0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb | ||
|
||
* mainnet: `0x23716E2dCC327429253335E4646dEbaD1Ac0E57c` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainnet: 0x23716E2dCC327429253335E4646dEbaD1Ac0E57c
testnet: 0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb | ||
|
||
* mainnet: `0x23716E2dCC327429253335E4646dEbaD1Ac0E57c` | ||
* testnet: `0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testnet: 0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb
Hi @KolomboPulse 👋 - thank you for your earlier comments on this PR. Can you help to share a little more context please so that I may help you? |
@@ -17,7 +17,7 @@ contract PriceContract is UsingFetch { | |||
constructor(address payable _fetchAddress) UsingFetch(_fetchAddress) {} | |||
|
|||
function getPrice() public view returns (uint256) { | |||
bytes32 _plsQueryId = keccak256(abi.encode("SpotPrice", abi.encode("pls", "usd"))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update readme fetch integration docs #10
@@ -196,9 +195,6 @@ npm i | |||
npm test | |||
``` | |||
|
|||
# Implementing using Fetch | |||
See our documentation for implementing usingFetch [here.](https://docs.fetchoracle.com/fetch/getting-data/introduction) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See our documentation for implementing usingFetch [here.]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update readme fetch integration docs #10
@@ -196,9 +195,6 @@ npm i | |||
npm test | |||
``` | |||
|
|||
# Implementing using Fetch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.