update readme fetch integration docs #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +17,7 @@ contract PriceContract is UsingFetch { | |||
| constructor(address payable _fetchAddress) UsingFetch(_fetchAddress) {} | |||
|
|
|||
| function getPrice() public view returns (uint256) { | |||
| bytes32 _plsQueryId = keccak256(abi.encode("SpotPrice", abi.encode("pls", "usd"))); | |||
| bytes32 _plsQueryId = keccak256(abi.encode("SpotPrice", abi.encode("llpls", "usd"))); | |||
| @@ -31,9 +31,8 @@ contract PriceContract is UsingFetch { | |||
|
|
|||
| Find Fetch contract addresses: | |||
|
|
|||
| mainnet: 0x6f390b99201bb43A05757019efe9C99651e04584 | |||
There was a problem hiding this comment.
mainnet: 0x6f390b99201bb43A05757019efe9C99651e04584
| @@ -31,9 +31,8 @@ contract PriceContract is UsingFetch { | |||
|
|
|||
| Find Fetch contract addresses: | |||
|
|
|||
| mainnet: 0x6f390b99201bb43A05757019efe9C99651e04584 | |||
| testnet: 0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb | |||
There was a problem hiding this comment.
testnet: 0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb
| mainnet: 0x6f390b99201bb43A05757019efe9C99651e04584 | ||
| testnet: 0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb | ||
|
|
||
| * mainnet: `0x23716E2dCC327429253335E4646dEbaD1Ac0E57c` |
There was a problem hiding this comment.
mainnet: 0x23716E2dCC327429253335E4646dEbaD1Ac0E57c
| testnet: 0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb | ||
|
|
||
| * mainnet: `0x23716E2dCC327429253335E4646dEbaD1Ac0E57c` | ||
| * testnet: `0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb` |
There was a problem hiding this comment.
testnet: 0x252eC80dEa7F3eD0CC57e0f1112d6f56Ae9523fb
KolomboPulse
approved these changes
Sep 21, 2024
|
Hi @KolomboPulse 👋 - thank you for your earlier comments on this PR. Can you help to share a little more context please so that I may help you? |
| @@ -17,7 +17,7 @@ contract PriceContract is UsingFetch { | |||
| constructor(address payable _fetchAddress) UsingFetch(_fetchAddress) {} | |||
|
|
|||
| function getPrice() public view returns (uint256) { | |||
| bytes32 _plsQueryId = keccak256(abi.encode("SpotPrice", abi.encode("pls", "usd"))); | |||
| @@ -196,9 +195,6 @@ npm i | |||
| npm test | |||
| ``` | |||
|
|
|||
| # Implementing using Fetch | |||
| See our documentation for implementing usingFetch [here.](https://docs.fetchoracle.com/fetch/getting-data/introduction) | |||
There was a problem hiding this comment.
See our documentation for implementing usingFetch [here.]
KolomboPulse
suggested changes
Sep 23, 2024
| @@ -196,9 +195,6 @@ npm i | |||
| npm test | |||
| ``` | |||
|
|
|||
| # Implementing using Fetch | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.