-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second fastd instance for backbone traffic #200
base: master
Are you sure you want to change the base?
Conversation
1ba22ca
to
bec6468
Compare
|
Please check #128 which is another atempt by @ohrensessel |
Didn't remember that one. I think this PR is more up time than #128. But the old one introduce other features we currently have not. Namely the cypher methods, but that should be done in another PR. Let us bring this one in. I have closed the old one. |
Anyone tested my changes yet? I'd like someone to approve it before merging |
70b4764
to
6d8bf60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me except for the batman_code parameter.
I haven't done any test runs, but from experience this should run fine.
@@ -94,6 +104,22 @@ | |||
ip_prefixlen => $mesh_ipv6_prefixlen; | |||
} | |||
|
|||
if $fastd_igw_enable { | |||
Class['ffnord::ntp'] -> ffnord::fastd { "fastd_igw_${mesh_code}": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not entirely obvious why this should be applied after the ntp service is setup.
@@ -66,6 +75,7 @@ | |||
} -> | |||
ffnord::fastd { "fastd_${mesh_code}": | |||
mesh_code => $mesh_code, | |||
batman_code => $mesh_code, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need an extra parameter batman_code, when it is the same as mesh_code, in all applied situations?
No description provided.