deterministic proxy deployment docs: draft #2309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@longfeiWan9 for review, because for some reason I can't mark you as a reviewer. @trruckerfling for merge when done |
lanzafame
reviewed
Sep 16, 2024
|
|
||
| ## Creating a deterministic deployment | ||
|
|
||
| Contract address can be precomputed, before the contract is deployed, using a create opcode. This is one of the options for deterministic deployment. |
There was a problem hiding this comment.
Suggested change
| Contract address can be precomputed, before the contract is deployed, using a create opcode. This is one of the options for deterministic deployment. | |
| A contract address can be precomputed, before the contract is deployed, using a create opcode. This is one of the options for deterministic deployment. |
Comment on lines
31
to
53
| ## **Deploying a factory contract to Filecoin** | ||
|
|
||
| Other people may have already deployed the factory contract onto Filecoin, in which case you won't need to redeploy it. You can just use the factory to deploy your contracts. So first check the expected address on a blockchain explorer to see if a factory contract already exists there. | ||
|
|
||
| If there isn't one yet then you'll need to deploy the factory contract via a **reusable signed raw deployment transaction**. The factory contract will then have the same address as on other blockchains (as long as the transaction bytecode stays the same). See the steps below to deploy the factory. | ||
|
|
||
| 1. **Prepare the deployment transaction:** | ||
| - Write the smart contract code for the factory contract. | ||
| - Compile the contract to get the bytecode. | ||
| - Create a deployment transaction with the bytecode. | ||
|
|
||
| 2. **Sign the deployment transaction:** | ||
| - Use a private key to sign the deployment transaction. | ||
| - Ensure the private key is securely stored and not exposed. | ||
|
|
||
| 3. **Broadcast the signed transaction:** | ||
| - Send the signed transaction to the desired blockchain network. | ||
| - Wait for the transaction to be mined and confirmed. | ||
|
|
||
| 4. **Verify the deployment:** | ||
| - Check the [blockchain explorer](https://docs.filecoin.io/networks/mainnet/explorers) to verify that the factory contract has been deployed to the expected address. | ||
| - Ensure the contract code matches the expected bytecode. | ||
|
|
There was a problem hiding this comment.
Why not make use of one of the factory contracts listed at the bottom of the document and make this an actual deployment example/tutorial, instead of just a list of steps. I don't think there is much benefit in stating Write the smart contract code for the factory contract in a document that, as far as I can tell, is aimed at people who don't necessarily know what deterministic deployments are at the start of the document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.