feat: basic jwt support #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchardin
commented
Oct 11, 2023
tchardin
commented
Oct 11, 2023
tchardin
commented
Oct 11, 2023
| @@ -18,13 +20,15 @@ class Saturn { | |||
| clientId: randomUUID(), | |||
| cdnURL: 'saturn.ms', | |||
| logURL: 'https://twb3qukm2i654i3tnvx36char40aymqq.lambda-url.us-west-2.on.aws/', | |||
| authURL: 'https://fz3dyeyxmebszwhuiky7vggmsu0rlkoy.lambda-url.us-west-2.on.aws/', | |||
There was a problem hiding this comment.
This is the staging lambda url, will switch with prod when we upgrade
DiegoRBaquero
approved these changes
Oct 11, 2023
tchardin
force-pushed
the
tc/jwt-support
branch
from
1bdd38f
to
a2e8ce7
Compare
guanzo
reviewed
Oct 11, 2023
guanzo
approved these changes
Oct 11, 2023
|
tests failing due to new clientKey requirement.. just add random clientKey to our test clients? |
|
I just realized that test clients perform fetches, so the JWT fetching logic will be called as well.., requiring a real clientKey for the target environment. How should we proceed? Do we mock out the authURL or somethin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.