enhancement: error handling + exp flag #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmeanAsad
commented
Oct 27, 2023
| @@ -54,7 +56,7 @@ export class Saturn { | |||
| this._monitorPerformanceBuffer() | |||
| } | |||
| this.storage = this.opts.storage || memoryStorage() | |||
| this.loadNodesPromise = this._loadNodes(this.opts) | |||
| this.loadNodesPromise = this.opts.experimental ? this._loadNodes(this.opts) : null | |||
There was a problem hiding this comment.
@DiegoRBaquero added this to only load nodes for the % we desire per a / b testing.
guanzo
reviewed
Oct 27, 2023
src/client.js
Outdated
| @@ -81,7 +83,7 @@ export class Saturn { | |||
| } | |||
| } | |||
|
|
|||
| const origins = options.origins | |||
| const origins = options.origins || [options.cdnURL] | |||
There was a problem hiding this comment.
if options.origins is an empty array it's still truthy so it won't fallback to cdnURL, is that ok here?
There was a problem hiding this comment.
not ok, thanks for flagging. I've added more logic to handle this better.
src/client.js
Outdated
| @@ -81,7 +83,7 @@ export class Saturn { | |||
| } | |||
| } | |||
|
|
|||
| const origins = options.origins | |||
| const origins = options.origins || [options.cdnURL] | |||
There was a problem hiding this comment.
Suggested change
| const origins = options.origins || [options.cdnURL] | |
| const origins = options.origins ?? [options.cdnURL] |
There was a problem hiding this comment.
@DiegoRBaquero updated this with your suggestion and eric's comment above
DiegoRBaquero
approved these changes
Oct 27, 2023
DiegoRBaquero
approved these changes
Oct 27, 2023
guanzo
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: