-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish logging #5
Conversation
…k iterator installs a ipfs-unixfs-exporter fork for DFS traversal
* Record bytes transferred * Record request duration after download finishes or errors * Report verification errors
} | ||
} catch (err) { | ||
log.ifNetworkError = err.message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does "if network error" mean here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it just means a fetch
error occurred because it only throws for network errors. The "if" prefix is a bit wonky but somebody thought it was a better naming scheme.
This should make the js-client ready for production use by the service worker or anyone else.
Logging:
Due to time constraints, I had to fork js-ipfs-unixfs and implement DFS traversal.