Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hoisted userManagementClient and providerConfigClient into baseClient #317

Merged
merged 2 commits into from
Dec 21, 2019
Merged

Hoisted userManagementClient and providerConfigClient into baseClient #317

merged 2 commits into from
Dec 21, 2019

Conversation

hiranya911
Copy link
Contributor

As of the last release the documentation doesn't list our public API surface correctly (see golang/gddo#664).

This fixes the issue by essentially absorbing userManagementClient and providerConfigClient into the baseClient.

lahirumaramba
lahirumaramba approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Hiranya!
LGTM!

@hiranya911 hiranya911 merged commit d30698d into dev Dec 21, 2019
@hiranya911 hiranya911 deleted the hkj-embed-hoist branch December 21, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiranya911 @lahirumaramba