Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Update versions for Release 10.18.0 #12033

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 1, 2023

Screenshot 2023-10-31 at 9 39 36 PM

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on acceptable CI

@TokenPayId
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)
Generated by 🚫 Danger

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    Overall coverage changed from 61.52% (24be340) to 61.65% (b277f68) by +0.13%.

    FilenameBase (24be340)Merge (b277f68)Diff
    FIRDynamicLinks.m71.30%71.84%+0.53%
  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.09% (24be340) to 88.17% (b277f68) by +0.08%.

    FilenameBase (24be340)Merge (b277f68)Diff
    exception.cc23.68%84.21%+60.53%
    leveldb_key.cc98.82%98.43%-0.39%
    ordered_code.cc93.90%94.39%+0.49%
  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from 94.76% (24be340) to 94.71% (b277f68) by -0.05%.

    FilenameBase (24be340)Merge (b277f68)Diff
    FPRGaugeManager.m97.39%95.42%-1.96%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dRTjJN0ENQ.html

@ncooke3
Copy link
Member Author

ncooke3 commented Nov 1, 2023

@ncooke3
Copy link
Member Author

ncooke3 commented Nov 1, 2023

I see they affected the nightly zip as well. The error though seems to be Xcode related:

xcodebuild: error: Unable to find a destination matching the provided destination specifier:
		{ platform:iOS Simulator, OS:latest, name:iPhone 15 }

	The requested device could not be found because no available devices matched the request.

@paulb777
Copy link
Member

paulb777 commented Nov 1, 2023

No, but they're almost certainly a regression from #11983, so shouldn't block this PR. I'll investigate today.

@ncooke3 ncooke3 enabled auto-merge (squash) November 1, 2023 15:22
@ncooke3 ncooke3 merged commit d832393 into master Nov 1, 2023
351 of 361 checks passed
@ncooke3 ncooke3 deleted the version-10.18 branch November 1, 2023 15:34
@firebase firebase locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants