Skip to content

Commit

Permalink
Report errors in configs, and load configs from anywhere (#7650)
Browse files Browse the repository at this point in the history
* Validate .yaml files and add "Open folder" button

* Fix dataconnect error

* Use RC file as source of truth for the current project ID.

This avoids the extension overwriting the selected project if the RC file is manually edited.

* Refactor subscriptions

* Lod nested configs

* Onboarding changes

* Revert changes extracted into separate PRs

* Make TS happy

* Update config logic to show dropdown when 2+ firebase.json are detected

* Remove logs

* Fix if

* Use effect cleanup

* Add doc to follow

* Use effect cleanup again

* Remove `if`

---------

Co-authored-by: Harold Shen <hlshen@google.com>
  • Loading branch information
rrousselGit and hlshen authored Oct 21, 2024
1 parent 4d87465 commit 4a2819d
Show file tree
Hide file tree
Showing 12 changed files with 600 additions and 312 deletions.
10 changes: 10 additions & 0 deletions firebase-vscode/common/messaging/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export interface WebviewToExtensionParamsMap {
*/
getInitialData: {};
getInitialHasFdcConfigs: void;
getInitialFirebaseConfigList: void;

addUser: {};
logout: { email: string };
Expand All @@ -43,6 +44,9 @@ export interface WebviewToExtensionParamsMap {
/** Trigger project selection */
selectProject: {};

/** When 2+ firebase.json are detected, the user can manually pick one */
selectFirebaseConfig: string;

/**
* Prompt user for text input
*/
Expand Down Expand Up @@ -123,6 +127,12 @@ export interface ExtensionToWebviewParamsMap {
infos?: RunningEmulatorInfo | undefined;
};

/** Lists all firebase.json in the workspace */
notifyFirebaseConfigListChanged: {
values: string[];
selected: string | undefined;
};

notifyEmulatorsHanging: boolean;

/** Triggered when new environment variables values are found. */
Expand Down
Loading

0 comments on commit 4a2819d

Please sign in to comment.