Cleaning up remnants of old vsce publish script #7856
Merged
+4
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7856 +/- ##
==========================================
+ Coverage 51.26% 51.36% +0.09%
==========================================
Files 421 421
Lines 29101 29198 +97
Branches 5944 5965 +21
==========================================
+ Hits 14920 14997 +77
- Misses 12848 12860 +12
- Partials 1333 1341 +8 ☔ View full report in Codecov by Sentry. |
hlshen
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
You don't need to check for gsutil anymore
There was a problem hiding this comment.
Good catch, removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up the VSCE publish script - this is being moved to kokoro, so it is longer needed here.