Set FIREBASE_BINARY as "firebasePath" user setting #7857
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
requested changes
Oct 21, 2024
yuchenshi
approved these changes
Oct 21, 2024
| @@ -63,7 +63,8 @@ | |||
| }, | |||
| "firebase.firebasePath": { | |||
| "type": "string", | |||
| "markdownDescription": "%ext.config.firebasePath%" | |||
| "markdownDescription": "%ext.config.firebasePath%", | |||
| "scope": "application" | |||
There was a problem hiding this comment.
Upon a closer look, I think we want machine-overridable. To quote the scope section in the schema, emphasis mine:
machine- Machine specific settings that can be set only in user settings or only in remote settings. For example, an installation path which shouldn't be shared across machines.
machine-overridable- Machine specific settings that can be overridden by workspace or folder settings.
The -overridable is mostly so that developers can pin to a different CLI / Node.js version for a certain workspace folder if they really want to. We won't programatically set workspace-level overrides though, it's all up to the developer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.