Skip to content

fix(ai): reuse a persistent http.Client in HttpApiClient - #18603

Open
SelaseKay wants to merge 1 commit into
mainfrom
fix/18602-http-client-reuse
Open

fix(ai): reuse a persistent http.Client in HttpApiClient#18603
SelaseKay wants to merge 1 commit into
mainfrom
fix/18602-http-client-reuse

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

HttpApiClient fell back to http.post / Request.send() when no client was injected. Those helpers create and close an http.Client per call, which tears down the TCP/TLS connection and forces a fresh handshake on every generateContent.

This keeps a long-lived http.Client on each HttpApiClient (httpClient ?? http.Client()) so keep-alive reuse can work for the lifetime of the model. Injected clients are unchanged. idleTimeout is still the dart:io default (15s); apps that need a longer pool can already pass a tuned IOClient via FirebaseAI.generativeModel(httpClient: …).

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Test plan

  • flutter test test/client_test.dart in packages/firebase_ai/firebase_ai (3 tests passed)
  • Confirm default generateContent still works against a real backend
  • Optional: two back-to-back calls within 15s should reuse the connection (no extra handshake)

Default generateContent calls used package:http helpers that create and
close a Client per request, forcing a fresh TCP/TLS handshake every time.

Fixes #18602
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay
SelaseKay marked this pull request as ready for review August 21, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 [firebase_ai] HttpApiClient creates a new http.Client per request — no TCP/TLS connection reuse

1 participant