Revert "[Infra] Embed frameworks scripts/add_framework_script.rb"
#1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reverting to avoid many failures during the nightlies. This is part of the solution to embedding frameworks in our tests, but there is more to be done that I haven't yet figured out. There are other failures that this causes (https://github.com/firebase/firebase-ios-sdk/actions/runs/8837847313) and I'm still trying to figure out why they are happening. After downloading the CI artifacts, it seems like the framework archives are not being stripped so there are a few inconsistencies with other sample projects I've worked with. |
paulb777
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1576