[FEATURE] display attribute value of child product in cart #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprankhub
reviewed
Oct 11, 2022
| @@ -42,8 +43,34 @@ public function __construct(GetVisibleCheckoutAttributesServiceInterface $getVis | |||
| public function afterGetCustomOptions(Configuration $configuration, array $customOptions, ItemInterface $item) | |||
| { | |||
| $attributes = $this->getVisibleCheckoutAttributesService->execute(); | |||
|
|
|||
| $configurableAttributes = $item->getOptionByCode('attributes') ? $item->getOptionByCode('attributes')->getValue() : []; | |||
| $configurableAttributes = $configurableAttributes ? array_keys(json_decode($configurableAttributes, true)) : []; | |||
There was a problem hiding this comment.
I did not check how this is encoded, but most probably, we should use \Magento\Framework\Serialize\Serializer\Json instead of directly using json_decode?
...Catalog/Helper/Product/Configuration/AddVisibleInCheckoutAttributesToCustomOptionsPlugin.php
Outdated
Show resolved
Hide resolved
|
Thanks for your contribution, @rommelfreddy! Could you check my comments and the failing pipeline? I think the change makes sense, but I would love to get a second opinion from e.g. @frostblogNet :) |
|
@rommelfreddy thanks for the contribution. It would be nice if you could change the line metioned by @sprankhub. Sorry for the late response. |
…utAttributesToCustomOptionsPlugin.php Make comparison stricter Co-authored-by: Simon Sprankel <sprankhub@users.noreply.github.com>
|
@roman204, if you want to push this forward, feel free to send a new PR with the changes fixed. Since I don't need this at the moment and my time is very limited, I cannot just work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR - thank you!
Issue
none
Proposed changes
this PR prints the child-attribute value in the cart instead of the configurable attribute value.
This makes more sense, cause the admin would change the value in the child below. E.g. the SKU.