Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build for UnoR4 Wifi/Minima #168

Merged
merged 6 commits into from
Oct 6, 2024
Merged

Fix build for UnoR4 Wifi/Minima #168

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23ae81b
Improve output
pgrawehr Aug 21, 2024
c5e2c29
This apparently never worked correctly
pgrawehr Aug 21, 2024
36c3fb3
Fix build for UnoR4 Wifi/Minima
pgrawehr Sep 12, 2024
1ef7af7
Add Uno R4 Wifi to list of toolchains to test compilation against
pgrawehr Sep 15, 2024
b858ba5
Rename IS_PIN_ANALOG and IS_PIN_PWM to avoid conflicts
pgrawehr Sep 15, 2024
4e5e946
Fix a deprecation warning
pgrawehr Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions examples/ConfigurableFirmata/ConfigurableFirmata.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,6 @@ void systemResetCallback()
else if (IS_PIN_DIGITAL(i))
{
Firmata.setPinMode (i, PIN_MODE_OUTPUT);
// Uncomment following 2 lines, if you want to start the board at HIGH output state on powering up:
// Firmata.digitalWrite(i, HIGH);
// Firmata.setPinState (i, HIGH);
}
}
#endif
Expand Down
2 changes: 1 addition & 1 deletion src/FirmataExt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ void handleSetPinModeCallback(byte pin, int mode)
void handleSysexCallback(byte command, byte argc, byte* argv)
{
if (!FirmataExtInstance->handleSysex(command, argc, argv)) {
Firmata.sendString(F("Unhandled sysex command"));
Firmata.sendStringf(F("Unhandled sysex command: 0x%x (len: %d)"), (int)command, (int)argc);
}
}

Expand Down
5 changes: 0 additions & 5 deletions src/utility/Boards.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,13 +808,8 @@ static inline void attachInterrupt(pin_size_t interruptNumber, voidFuncPtr callb
#define TOTAL_ANALOG_PINS 8
#define TOTAL_PINS 22 // 14 digital + 8 analog
#endif
// These have conflicting(?) definitions in the core for this CPU
#undef IS_PIN_PWM
#undef IS_PIN_ANALOG
#define VERSION_BLINK_PIN 13
#define IS_PIN_DIGITAL(p) ((p) >= 2 && (p) <= 19)
#define IS_PIN_ANALOG(p) ((p) >= 14 && (p) < 14 + TOTAL_ANALOG_PINS)
#define IS_PIN_PWM(p) digitalPinHasPWM(p)
#define IS_PIN_SERVO(p) (IS_PIN_DIGITAL(p) && (p) - 2 < MAX_SERVOS)
#define IS_PIN_I2C(p) ((p) == 18 || (p) == 19)
#define IS_PIN_SPI(p) ((p) == SS || (p) == MOSI || (p) == MISO || (p) == SCK)
Expand Down