Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2FA for webtrees attempt #2 #5039

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

kbwhizz
Copy link

@kbwhizz kbwhizz commented Oct 9, 2024

Adds ability for user to switch on preference in account which makes a QR code appear. This can be scanned by a Google authenticator app and the secret is saved. At next log in, user must enter the code for the site from the authenticator when they log in. Can be switched off from account too. Incorporated into setup wizard and any add/edit user functions.

@kiwi3685
Copy link
Contributor

Sorry if this is already included, but I couldn't find it.

Just a personal opinion, but I would prefer to have an administrator option to enable (or not) 2FA on my site, before users are offered the option.

@kbwhizz
Copy link
Author

kbwhizz commented Oct 10, 2024

Sorry if this is already included, but I couldn't find it.

Just a personal opinion, but I would prefer to have an administrator option to enable (or not) 2FA on my site, before users are offered the option.

It isn't there at present. What screen would that option appear on. Couldn't see anything obvious in control panel.

@kiwi3685
Copy link
Contributor

Perhaps Control panel > Website > Sign-in and registration? Seems the most logical.

@kbwhizz
Copy link
Author

kbwhizz commented Oct 11, 2024

Perhaps Control panel > Website > Sign-in and registration? Seems the most logical.

Now added to code and pushed to repo (I hope)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants