-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed illegal partition assign from input.py #673
Conversation
Die für einen subscription based consumer illegale Operation "assign(topic_partition)" aus _lost_callback entfernt.
removed illegal partition assign from input.py
Thank you for your PR. The language in this project is English. So please write only in English. Until that happen I revert this PR into a draft. |
For subscription based consumers it is not allowed/iilegal to use "assign(topic_partition)". Therefore I removed the offending code from _lost_callback. |
New entry in Bugfix section
Updated changelog provided in PR #674 . |
could you add all means depending this change in this pull request please? It is not necessary to open further PRs. |
Update CHANGELOG.md
Was some fiddeling, but now this PR includes also the CHANGELOG.md. |
i triggered the pipeline again. have a look in the failing unittests and in the code quality job. there you are able to see, what is failing |
Done, but I do not understand what issue it is complaining about. |
corrected identation on blank line in input.py
Removed identation on blank line. |
Removing additional whitespaces in input.py
Now the linter complains about code I did not touch. |
close because will be addressed by #678 |
Die für einen subscription based consumer illegale Operation "assign(topic_partition)" aus _lost_callback entfernt.
Ggf. muss noch irgendwas aufgeräumt werden.
Da diese Partitionen potentiell bereits von einem anderen Consumer bearbeitet werden, passt "batch_finished" nicht. Das könnte zu Chaos bei den Offsets führen.
Ob ein "output_connector._write_backlog" Chaos auf der Output Seite auslösen kann, kann ich nicht beurteilen.