preserve attachment metadata after validation errors - #229
Merged
flack merged 2 commits intoAug 14, 2026
Conversation
flack
reviewed
Aug 14, 2026
| return; | ||
| } | ||
|
|
||
| file_put_contents($attachment->location . '.metadata', json_encode([ |
Owner
There was a problem hiding this comment.
if we're going to store this on the file system, there would need to be some cleanup at some point, otherwise these files will accumulate forever.
Another option might be to save this kind of stuff in midcom (or maybe system) temp dir, which get cleaned periodically
Owner
There was a problem hiding this comment.
looking at the code some more, is att->location inside the tempdir at this point already? If so, maybe add a comment to that effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.