Add describer to Python API's Omorfi class #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 15, 2018
| ## whether UDPipe is loaded | ||
| self.can_udpipe = False | ||
| ## whether to use full lexicon/describe FST |
There was a problem hiding this comment.
too many leading '#' for block comment
| @@ -120,8 +126,12 @@ def __init__(self, verbosity=False): | |||
| self.can_labelsegment = False | |||
| ## whether guesser model is loaded | |||
| self.can_guess = False | |||
| ## whether describer model is loaded | |||
There was a problem hiding this comment.
too many leading '#' for block comment
| @@ -84,6 +88,8 @@ def __init__(self, verbosity=False): | |||
| self.acceptor = None | |||
| ## guesser model | |||
| self.guesser = None | |||
| ## describer model | |||
There was a problem hiding this comment.
too many leading '#' for block comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the nicest way to do this. It might turn out nicer if the Omorfi class was split into one to manage FSTs and one to do analysis which would take the FST(s) it should use as an argument.