fix: filter the case when sn is empty #941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
再加一个其他os的处理吧，除了windows linux 还应该有个分支。比如之前群里有人用mac做编译机 或者mac本地无法测试了 |
虽然可以通过不返回err 处理，但是遇到非 windows 非 linux的os，单独一个分支更明显。 |
好的，之前只测Centos、ubuntu、openeuler还有window了，一会加一个mac吧。 |
windows linux other ，供参考 |
add sn get method for darwin
return error for other os when get sn
|
重新提了pr，之前那个分支，提交提乱了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if bios sn is empty or getting fail, it is ok