lib: Print error messaage from load_config function when panicing - #167
Merged
barthalion merged 1 commit intoAug 24, 2026
Merged
Conversation
dcbaker
force-pushed
the
submit/propogate-config-errors
branch
from
August 13, 2026 18:13
827b0fa to
2d784dc
Compare
The current implementation discards the essential information of the error, such as whether the file was missing, or unreadable, or if there was an error in deserializing. This adds the underlying error message to the panic, which can help debug invalid configurations. Related: flatpak#156
barthalion
force-pushed
the
submit/propogate-config-errors
branch
from
August 23, 2026 21:24
2d784dc to
3b37793
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation discards the essential information of the error, such as whether the file was missing, or unreadable, or if there was an error in deserializing. This adds the underlying error message to the panic, which can help debug invalid configurations.
Related: #156