Network Manager #148
LorenzoMorolint.yaml
on: pull_request
Lint golang files
4m 13s
Enforce go.mod tidiness
2m 31s
Lint bash files
4s
Lint markdown files
17s
Annotations
6 errors and 6 warnings
|
Lint golang files:
pkg/utils/tools/tools.go#L29
paramTypeCombine: func(h int, m int, s int) string could be replaced with func(h, m, s int) string (gocritic)
|
|
Lint golang files:
pkg/utils/resourceforge/forge.go#L1436
paramTypeCombine: func(id string, address string) *networkv1alpha1.KnownCluster could be replaced with func(id, address string) *networkv1alpha1.KnownCluster (gocritic)
|
|
Lint golang files:
pkg/network-manager/network-controller.go#L61
commentedOutCode: may want to remove commented-out code (gocritic)
|
|
Lint golang files:
pkg/network-manager/network-controller.go#L254
rangeValCopy: each iteration copies 312 bytes (consider pointers or indexing) (gocritic)
|
|
Lint golang files:
pkg/network-manager/network-controller.go#L256
G601: Implicit memory aliasing in for loop. (gosec)
|
|
Lint golang files
issues found
|
|
Enforce go.mod tidiness
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint golang files
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v4, golangci/golangci-lint-action@v3.7.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint golang files:
apis/network/v1alpha1/knowncluster_status.go#L19
exported: comment on exported method KnownCluster.UpdateStatus should be of the form "UpdateStatus ..." (revive)
|
|
Lint golang files:
pkg/utils/namings/namings.go#L127
exported: comment on exported function ForgeKnownClusterName should be of the form "ForgeKnownClusterName ..." (revive)
|
|
Lint golang files:
pkg/network-manager/network-controller.go#L60
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint golang files:
pkg/network-manager/network-controller.go#L107
exported: exported function Execute should have comment or be unexported (revive)
|