feat: migrate from dart_skills_lint to skills_lint package - #226
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the local dart_skills_lint package from the workspace and migrates the repository to use the external skills_lint package from GitHub. The configuration file has been updated to use the skills_lint key, and all imports in custom rules and tests have been updated accordingly. I have no feedback to provide as there are no review comments.
cf7da2d to
93fb0ef
Compare
| final errors = <ValidationError>[]; | ||
| final yaml = context.parsedYaml; | ||
| if (yaml == null) return errors; | ||
| if (yaml == null) { |
There was a problem hiding this comment.
Intentional change to make this rule better handle edge cases. It should not pass on a malformed frontmatter.
There was a problem hiding this comment.
There is some annoying directory manipulation in this test. I filed google/skills_lint.dart#2 to make it better in the future and the naive solution failed if you ran the test from the root instead of from the generator directory.
| await runner.run(['validate-skill', configFile.path]); | ||
| }, getCurrentDirectory: () => tempDir); | ||
|
|
||
| expect( |
There was a problem hiding this comment.
This was a duplicate line. I also think there are duplicate tests but decided to keep my change in this file to only the duplicate validation.
3 participants
This pr was agent authored but it modifies a workflow and reidbaker-agent does not have workflow scope.
The skills_lint code is moving out of this repo to its own github repo github.com/google/skills_lint.dart.
While working the agent found a duplicate test code so I removed that as well.
Agent authored description
Migrates from the legacy
dart_skills_lintpackage to the standaloneskills_lintpackage hosted ingoogle/skills_lint.dart, updating configurations, test imports, workspace definitions, and CI path triggers.