Fix "gclient sync" call in "dt serve" for Windows - #9976
Merged
Conversation
On Windows, shell scripts must be invoked with their ".bat" suffix. Without this fix, "gclient sync" would fail when called by "dt serve".
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a helper function shellScriptName in tool/lib/utils.dart to determine the correct shell script name based on the platform (appending .bat on Windows). It refactors FlutterSdk and CliCommand to use this helper, reducing code duplication. The review feedback points out a minor typo ("them them") in the documentation comment of the new helper function.
srawlins
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, shell scripts must be invoked with their ".bat" suffix. Without this fix, "gclient sync" would fail when called by "dt serve".