Conversation
Changes in webpack 5.110.0 cause build failures due to issue webpack/webpack#21844: ``` 11:28:15 HookWebpackError: Transform failed with 1 error: 11:28:15 /etc/folio/stripes/node_modules/esbuild/lib/main.js:534:29: ERROR: "minify" must be a boolean 11:28:15 at makeWebpackError (/etc/folio/stripes/node_modules/webpack/lib/errors/HookWebpackError.js:76:9) ... ``` webpack 5.110.0 changed the shape of `optimization.minify` in a way that makes esbuild unhappy. This smells a bit like the compatibility problems we have previously discovered between our JS code that may pass a falsey value to react-query, written in TS, where that falsey-but-not-strictly-false value is strictly compared to `false`, and fails. Here, webpack changed from passing `true` to passing an object (still truthy, of course), but esbuild expects strict `true` and blows up if it doesn't get it. Anyway, here we are. Isn't this fun? An emergency fix in platform-lsp pinned the version at the platform level under FOLIO-4563. This PR pins it at the source, where `webpack` is a direct dependency. See STRIPES-1043 for a fix in stripes-build. Refs STCLI-289
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in webpack 5.110.0 cause build failures due to issue webpack/webpack#21844:
webpack 5.110.0 changed the shape of
optimization.minifyin a way that makes esbuild unhappy. This smells a bit like the compatibility problems we have previously discovered between our JS code that may pass a falsey value to react-query, written in TS, where that falsey-but-not-strictly-false value is strictly compared tofalse, and fails. Here, webpack changed from passingtrueto passing an object (still truthy, of course), but esbuild expects stricttrueand blows up if it doesn't get it. Anyway, here we are. Isn't this fun?An emergency fix in platform-lsp pinned the version at the platform level under FOLIO-4563. This PR pins it at the source, where
webpackis a direct dependency. See STRIPES-1043 / folio-org/stripes-build#21 for a fix in stripes-build.Refs STCLI-289