efitools: fix do_deploy and keys check

[quaresmajose]

No description provided.

[quaresmajose]

Also requires foundriesio/lmp-manifest#463

[ldts]

${D} can be changed and used as a temporary storage however the new data will not be packed.
This is not a problem in this case since this firmware is being picked from the deploy folder. However - after our conversation- I understand it is formally incorrect and confusing to the reader using ${D} that way.

[ldts]

@quaresmajose the commit message is wrong. UnLock.efi is created at compile time. It is however signed at install time

[quaresmajose]

@quaresmajose the commit message is wrong. UnLock.efi is created at compile time. It is however signed at install time

right, I will change it to signed at install time

[quaresmajose]

${D} can be changed and used as a temporary storage however the new data will not be packed. This is not a problem in this case since this firmware is being picked from the deploy folder. However - after our conversation- I understand it is formally incorrect and confusing to the reader using ${D} that way.

This is not true, ${D} is not a temporary storage and is the image folder of the recipe.
Only the do_install task should create or modify content on that folder.

${D} is the output folder of the do_install
${B} is the output folder of the do_compile
${DEPLOYDIR} is the output folder of the do_deploy

In a perfect world D/B/DEPLOYDIR should be read/write only for the mentioned tasks.
but that's not what happens and these directories can be modified at any time in any task,
just because this is possible doesn't mean it's correct.

there a lot of directories used by bitbake:

T = "${WORKDIR}/temp"
D = "${WORKDIR}/image"
S = "${WORKDIR}/${BP}"
B = "${S}"

more https://git.yoctoproject.org/poky/plain/meta/conf/bitbake.conf

[ldts]

${D} can be changed and used as a temporary storage however the new data will not be packed. This is not a problem in this case since this firmware is being picked from the deploy folder. However - after our conversation- I understand it is formally incorrect and confusing to the reader using ${D} that way.

This is not true, ${D} is not a temporary storage and is the image folder of the recipe. Only the do_install task should create or modify content on that folder.

${D} is the output folder of the do_install ${B} is the output folder of the do_compile ${DEPLOYDIR} is the output folder of the do_deploy

In a perfect world D/B/DEPLOYDIR should be read/write only for the mentioned tasks. but that's not what happens and these directories can be modified at any time in any task, just because this is possible doesn't mean it's correct.

there a lot of directories used by bitbake:

T = "${WORKDIR}/temp"
D = "${WORKDIR}/image"
S = "${WORKDIR}/${BP}"
B = "${S}"

more https://git.yoctoproject.org/poky/plain/meta/conf/bitbake.conf

I did not say it is correct. I said that it can be used as temporary storage and the proof is that it does work as expected. What it is aboslutely not true is that it can not be used as temporary storage. Because it can.

A different question is why should anyone want to do that or if it is indeed correct using it for that purpose. Hence your commit.