Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock efi #1526

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Unlock efi #1526

wants to merge 2 commits into from

Conversation

ldts
Copy link
Contributor

@ldts ldts commented Oct 29, 2024

No description provided.

ldts and others added 2 commits October 29, 2024 17:26
@ldts
efitools: unlock: must have UEFI_SIGN_ENABLE
d92169b 
This tool requires user keys to be built.

Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
@quaresmajose @ldts
base: efitools: check if we have the keys in place
397bc39 
Instaed of faling with a python exception we can check if we have
all keys reqired and fail with a useful message if not.

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
@ldts
Copy link
Contributor Author

ldts commented Oct 30, 2024 •
edited
Loading

efitools:

case1

  • efitools builds userspace tools and lockdown/unlock EFI programs.
  • the efi programs only make sense when providing LmP keys (UEFI_SIGN_ENABLE)
  • they can be discarded otherwise as they provide no value for LmP
  • -> In fact the unlock.patch never contemplated not having the necessary keys to compile-in so it wont build

case2

  • The efi applications when built with UEFI_SIGN_ENABLE are installed from the deploy folder
  • They are not needed in install
  • It should be ok therefore to build and copy them to a temporary folder (WORKDIR) during deploy

@ricardosalveti ricardosalveti requested a review from a team October 30, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardosalveti ricardosalveti Awaiting requested review from ricardosalveti

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldts @quaresmajose