Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update account create docs #2517

Merged
merged 36 commits into from
Oct 15, 2024
Merged

Update account create docs #2517

merged 36 commits into from
Oct 15, 2024

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Sep 25, 2024 •
edited
Loading

Closes #2508

Introduced changes

  • Updated docs

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula kkawula marked this pull request as ready for review September 25, 2024 13:47
cptartur
cptartur requested changes Sep 27, 2024
View reviewed changes
docs/src/starknet/account.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Show resolved Hide resolved
docs/src/starknet/account.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Show resolved Hide resolved
@kkawula kkawula marked this pull request as draft October 1, 2024 09:57
@kkawula kkawula marked this pull request as ready for review October 1, 2024 10:08
cptartur
cptartur reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's restructure this following the offline discussion

@kkawula kkawula requested a review from cptartur October 8, 2024 13:17
cptartur
cptartur requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with this page, it looks much better now. Some additional comments.

docs/src/starknet/account.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Outdated Show resolved Hide resolved
cptartur
cptartur approved these changes Oct 14, 2024
View reviewed changes
docs/src/starknet/account.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Outdated Show resolved Hide resolved
docs/src/starknet/account.md Outdated Show resolved Hide resolved
@kkawula kkawula disabled auto-merge October 15, 2024 11:04
@kkawula kkawula added this pull request to the merge queue Oct 15, 2024
Merged via the queue into master with commit eacc4dd Oct 15, 2024
24 checks passed
@kkawula kkawula deleted the kkawula/2508-update-account-create-docs branch October 15, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@integraledelebesgue integraledelebesgue integraledelebesgue left review comments

@cptartur cptartur cptartur approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

@ksew1 ksew1 Awaiting requested review from ksew1

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update account create docs
4 participants
@kkawula @cptartur @franciszekjob @integraledelebesgue