feat(sncast): generate default name when using account import #2610
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khayss
requested review from
cptartur,
ddoktorski,
kkawula and
franciszekjob
as code owners
franciszekjob
requested changes
Oct 25, 2024
Comment on lines
+207
to
+215
| fn generate_default_account_name() -> String { | ||
| let start = SystemTime::now(); | ||
| let since_epoch = start | ||
| .duration_since(UNIX_EPOCH) | ||
| .expect("Time went backwards"); | ||
| let timestamp = since_epoch.as_millis(); | ||
| format!("account-{}", timestamp) | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's refactor this function to create account with sequential names (account-1, account-2, ...). Name with timestamp (e.g. account-1729865041172) is too complicated.
Our logic should find next available numer (and handle gaps, e.g. having account-1 and account-3 in file, imported account should receive name account-2).
You can see how accounts are read from the file here.
There was a problem hiding this comment.
Alright. This was my initial plan. I'll fall back to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2581
Introduced changes
All changes made are focused on
sncast.In
crates/sncast/src/starknet_commands/account/import.rs, I added a utility function to generate a random account name which is used to supply the account construct with a name where the user does not specify any to the Also updated the import function in this file by changing the function parameter to accept anOption<String>type foraccountparameter. This way, users can import accounts without requiringnameto be specified. Also, updated theImportstructnamekey to have a type ofOption<String>.In
crates/sncast/src/main.rs, I updated the argument feed into theimportfunctionaccountparameter.I updated the necessary documentation and logs.
Checklist
CHANGELOG.md