Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove RawForgeConfig abstraction #2615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: Remove RawForgeConfig abstraction #2615

wants to merge 1 commit into from
+93 −99

Conversation

bloomingpeach
Copy link

@bloomingpeach bloomingpeach commented Oct 26, 2024 •
edited
Loading

Closes #2514

Introduced changes

Derive Deserialize for ForgeConfigFromScarb and get rid of the RawForgeConfig abstraction

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

kkawula
kkawula requested changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@kkawula kkawula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bloomingpeach looks promising, but please adjust tests to your changes. You can check which tests failed in the CI summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkawula kkawula kkawula requested changes

@cptartur cptartur Awaiting requested review from cptartur cptartur is a code owner

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

@franciszekjob franciszekjob Awaiting requested review from franciszekjob franciszekjob is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove RawForgeConfig abstraction
2 participants
@bloomingpeach @kkawula