Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No internal styles rule proposal #311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

georgyangelov
Copy link

Proposal for a rule restricting breaking component encapsulation through style props

Description

First, this is a very crude WIP to see if you would accept such a rule. If you agree it's a good candidate I'll clean up the code and make it merge-ready. Please let me know what you think

Please see the docs/rules/no-internal-style.md file for an explanation of what the rule does.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@georgyangelov georgyangelov marked this pull request as ready for review January 18, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant