fix(sidebar): render nav items as real links so middle-click works

[itsdaveit]

Problem

Sidebar entries cannot be opened in a new tab. Middle-click, ctrl/cmd-click and the browser's "open link in new tab" all do nothing, because every item renders as a <button> — there is no link target for the browser to act on. The entries are also not exposed as links to assistive technology.

Cause

frappe-ui's SidebarItem already renders a RouterLink whenever a to prop is present and only falls back to <button> otherwise. AppSidebar never passes to, although every navigable item already knows its route target — it just used it inside the click handler (router.push).

Change

Pass the route target through as to for the three navigable item groups: nav items, saved views and the mobile notifications entry. Navigation is then performed by the router link itself, so selectItem() keeps only its side effects (setting the active item immediately, before the route settles, plus the caller's hook).

Items that have no route target — search and the notifications toggle — are unchanged and keep rendering as buttons.

Notes

• No visual change; SidebarItem renders identical markup in both branches.
• activeItem is still set eagerly for instant highlighting, and the existing route watcher keeps it in sync.
• Removes the now-unused useRouter/RouteLocationRaw imports.

Testing

Verified in a production Helpdesk instance: middle-click, ctrl-click and the context menu now open tickets, customers, contacts and saved views in a new tab; regular clicks and active-state highlighting are unaffected.

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[greptile-apps]

Confidence Score: 5/5

Safe to merge — the change is narrow, purely additive, and has no effect on visual output or existing click behaviour.

Only one file changed. Navigation now happens through the router link instead of router.push inside the click handler, but the outcome is identical. Items without a to prop continue rendering as buttons. No logic paths are removed that weren't replaced by an equivalent mechanism.

Files Needing Attention: No files require special attention.

_{Reviews (2): Last reviewed commit: "fix(sidebar): render nav items as real l..." | Re-trigger Greptile}