issues/842 #979
issues/842 #979
Conversation
I've included steps to setup the environment, install dependencies and run the application.
sites/common_site_config.json
Outdated
| @@ -0,0 +1,16 @@ | |||
| { | |||
There was a problem hiding this comment.
Why did you commit your common_site_config.json?
| @@ -0,0 +1,137 @@ | |||
| <p align="center"> | |||
| <a href="https://www.frappelms.com/"> | |||
There was a problem hiding this comment.
This is a copy of the Readme. Please remove this file.
|
|
||
|
|
||
| def get_common_context(context): | ||
| context.no_cache = 1 |
There was a problem hiding this comment.
Redundant changes from your other PR
| @@ -253,7 +253,7 @@ input[type=checkbox] { | |||
| background-position: center; | |||
| border: 1px solid var(--gray-400); | |||
| box-sizing: border-box; | |||
| box-shadow: 0 1px 2px #0000001a; | |||
| box-shadow: 0 1px 2px rgba(0, 0, 0, 0.1); | |||
There was a problem hiding this comment.
Redundant changes from your other PR
| frappe.throw( | ||
| _("Row #{0} Date cannot be outside the batch duration.").format(schedule.idx) | ||
| ) | ||
| if schedule.date is not None: |
There was a problem hiding this comment.
The could have been a part of the same if condition
| @@ -1,6 +1,6 @@ | |||
| import { useStorage } from "@vueuse/core"; | |||
| import { call } from "frappe-ui"; | |||
| import "../../../frappe/frappe/public/js/lib/posthog.js"; | |||
| // import "../../../frappe/frappe/public/js/lib/posthog.js"; | |||
There was a problem hiding this comment.
Why did you comment this?
| @@ -0,0 +1,20 @@ | |||
| import { defineStore } from 'pinia' | |||
|
|
|||
There was a problem hiding this comment.
Redundant changes from your other PR
| @@ -70,12 +70,14 @@ import UserAvatar from '@/components/UserAvatar.vue' | |||
| import { useRouter } from 'vue-router' | |||
| import { X } from 'lucide-vue-next' | |||
| import { updateDocumentTitle } from '@/utils' | |||
| import { useNotificationStore } from '@/stores/notificationStore' | |||
There was a problem hiding this comment.
Redundant changes from your other PR
| @click="markAllAsRead.submit" | ||
| :loading="markAllAsRead.loading" | ||
| @click="markAllAsRead" | ||
| :loading="markAllAsReadLoading" |
There was a problem hiding this comment.
Redundant changes from your other PR
| @@ -66,16 +66,20 @@ const announcement = reactive({ | |||
| }) | |||
|
|
|||
| const announcementResource = createResource({ | |||
| url: 'frappe.core.doctype.communication.email.make', | |||
| url: 'frappe.email.queue.send', | |||
There was a problem hiding this comment.
What is this solving? This would make a copy in Communication doctype
No description provided.