Change the AuthenticationTest log file name to indicate result #24
Conversation
Also include the number of clients and threads and whether all the authentications succeeded in the filename. This makes it easier to find success/failure and with the tuning of clients vs threads.
| total_threads, | ||
| total_successes | ||
| total_successes, |
There was a problem hiding this comment.
Here, if msg is fails, it will be shown alongside the successes (from total_successes). We could add a conditional so that fails are only shown if there were any, or to be consistent we can just show fails always and for a successful run it would show as 0fails (total_threads - total_succeses).
So it would behave like:
10 threads, 10 successes: 0fails
10 threads, 6 successes: 4fails
10 threads, 0 successes: 10fails
What do you think?
There was a problem hiding this comment.
Having something unique to regex on to find the successes when doing ranges of tests is handy. I guess 0fails could be that thing but just looking for success is simpler IMHO.
There was a problem hiding this comment.
Yeah, that works too. But then we can remove the msg variable and just put "successes" on the string.
Also include the number of clients and threads in the filename.
This makes it easier to find success/failure and with the tuning
of clients vs threads.