Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run arguments to results output #55

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

antoniotorresm
Copy link
Collaborator

Include the list of arguments for the run to the list of results.

Include the list of arguments for the run to the list of results.

Signed-off-by: Antonio Torres <antorres@redhat.com>
@rcritten
Copy link
Contributor

Test with an authentication test I'm running now. Matches the command-line and produces valid JSON.

[{"source": "ipaperftest.plugins.authenticationtest", "test": "AuthenticationTest", "result": "SUCCESS", "uuid": "7bb04c12-1412-4bbd-8863-8c5df34883de", "when": null, "duration": null, "kw": {"args": ["/home/rcrit/redhat/freeipa-perftest/venv/bin/ipaperftest", "--provider", "idmci", "--test", "AuthenticationTest", "--threads", "1", "--ad-threads", "1", "--amount", "14", "--idmci-lifetime", "6"]}},...

If this is for display and tracking purposes only then it's fine as-is. If we think at some point we might want to programmatically poke at the arguments then that would be difficult in its current form, other than ' '.join(args)

@rcritten
Copy link
Contributor

Antonio confirmed it's only for display. The purpose is to catch as much information on the run as possible.

@rcritten rcritten added the ack label Aug 24, 2023
@rcritten rcritten merged commit b566238 into freeipa:master Aug 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants