Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #4576, this PR adds support for storing queries from the Search API. It applies to the following scenarios:
Note that
hit_cache
will always be False on API Search queries. Since we don't have a cache implemented for the API.For the V3 API running on Elasticsearch, I added error handling since we weren’t previously catching Elasticsearch errors. This allows us to store and flag failed queries. Error messages and status codes remain consistent with those in V4 of the Search API.
Additional changes:
SearchQueryAdmin
with cursor pagination.ceil
method when storingquery_time
, as times are always integers (milliseconds).