Linterchecks #329
Closed
Linterchecks #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR still needed? |
|
Yes, it is, though it has a somewhat low priority to me. It should improve our code by a lot. If I understood @Noki right, he would really like to see this in the next release too. This should be rebased and then it should be fine. I think I marked it as draft, because I somehow mistrust, that all code executes exactly equal to the forme one. We can test this properly in an RC-Release though. |
Closed
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Fix some minor issues and set some shellcheck directive to satisfy the CI and clarify some thing for future programmers. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Signed-off-by: Martin Hübner <martin.hubner@web.de>
semver.sh is not our own library. We shouldn't check it therfore. This precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
adjust dependencies, to include jshn too. Signed-off-by: Martin Hübner <martin.hubner@web.de>
noteworthy: removed backtick-notation for subshell calls. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Shellcheck found some minor issues left, that were fixed with this commit. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Add a notice that autoupdate is licensed under GPL. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Signed-off-by: Martin Hübner <martin.hubner@web.de>
Signed-off-by: Martin Hübner <martin.hubner@web.de>
Signed-off-by: Martin Hübner <martin.hubner@web.de>
Signed-off-by: Martin Hübner <martin.hubner@web.de>
Signed-off-by: Martin Hübner <martin.hubner@web.de>
Signed-off-by: Martin Hübner <martin.hubner@web.de>
(cherry picked from commit 38591b0)
|
nevermind. This branch is not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only purpose of this PR is to run the new shelcheck-ci on the draft-pr #328. It will be closed, once it isn't useful anymore.