-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mesh announce #148
Update mesh announce #148
Conversation
We are not changing away from our root-only-infra anytime soon and I'm not using this role in sideprojects anymore.
they implemented a long awaited PR, where they'd change the config from arguments to one configfile. Look here for further reference: ffnord/mesh-announce#60
...temporarily to reduce unnecessary warnings about 'batctl -m'
Reviews are requested; I'll merge this today at around 18:00 as our current state is broken; and this wont break it more. Tested on sn07: |
Tested on sn01 as well. |
Will go on with 08 later to test for stretch issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity: why is the service called respondd, but the software is called mesh-announce?
Because mesh-announce provides the capabilities of respondd. The pattern is furthermore neat, as it makes conflicting providing services more obvious; hence try having two programs providing the same service dhcpd or respondd. In this provide-structure respondd or dhcpd are more or less standardized interfaces. |
Bad example. ;) Just yesterday it took me some time to find out, that its a bad idea to go against the package mantainer. Long story short: its isc-kea-dhcp4-server again. I see your point, but I think its more helpful/intuitive when all components (process name, config file, paths etc) of a software share the same name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can be merged.
Not a bad example, just not considered. If your PM deploys it as kea, it's kea. |
I did not want you to rename it. I was just curious. :) |
rolled out successfully on all supernodes |
This closes #146
More details in commit messages of PR-commits;
Basically upstream implemented ffnord/mesh-announce#60 .
We pulled from their master and broke our config.
This does not happen often; I'd vote for not changing the repos upstream because of this.