Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mesh announce #148

Merged
merged 6 commits into from
Feb 14, 2021
Merged

Update mesh announce #148

merged 6 commits into from
Feb 14, 2021

Conversation

AiyionPrime
Copy link
Member

@AiyionPrime AiyionPrime commented Feb 14, 2021

This closes #146

More details in commit messages of PR-commits;

Basically upstream implemented ffnord/mesh-announce#60 .
We pulled from their master and broke our config.
This does not happen often; I'd vote for not changing the repos upstream because of this.

We are not changing away from our root-only-infra anytime soon
and I'm not using this role in sideprojects anymore.
they implemented a long awaited PR, where they'd change the config from arguments to one configfile.
Look here for further reference:
ffnord/mesh-announce#60
...temporarily to reduce unnecessary warnings about 'batctl -m'
@AiyionPrime
Copy link
Member Author

Reviews are requested; I'll merge this today at around 18:00 as our current state is broken; and this wont break it more.

Tested on sn07:
https://hannover.freifunk.net/karte/#/en/map/88e640ba7021

@AiyionPrime
Copy link
Member Author

Tested on sn01 as well.

@AiyionPrime
Copy link
Member Author

Will go on with 08 later to test for stretch issues.

Copy link
Member

@1977er 1977er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity: why is the service called respondd, but the software is called mesh-announce?

@AiyionPrime
Copy link
Member Author

AiyionPrime commented Feb 14, 2021

Because mesh-announce provides the capabilities of respondd.
It's the same with your dhcp service.
Kea provides dhcpd, so the service is called dhcpd, because any sysadmin who'll come along would suffer a lot if he'd need to find out first, which dhcp server is currently used.

The pattern is furthermore neat, as it makes conflicting providing services more obvious; hence try having two programs providing the same service dhcpd or respondd.

In this provide-structure respondd or dhcpd are more or less standardized interfaces.

@1977er
Copy link
Member

1977er commented Feb 14, 2021

Bad example. ;) Just yesterday it took me some time to find out, that its a bad idea to go against the package mantainer. Long story short: its isc-kea-dhcp4-server again.

I see your point, but I think its more helpful/intuitive when all components (process name, config file, paths etc) of a software share the same name.

Copy link
Contributor

@lemoer lemoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can be merged.

@AiyionPrime
Copy link
Member Author

Not a bad example, just not considered. If your PM deploys it as kea, it's kea.
But the PM for mesh-announce calls it respondd, so I won't rename this, sorry.

@AiyionPrime AiyionPrime merged commit c995ae6 into master Feb 14, 2021
@1977er
Copy link
Member

1977er commented Feb 14, 2021

I did not want you to rename it. I was just curious. :)

@AiyionPrime
Copy link
Member Author

rolled out successfully on all supernodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

respondd not running on sn01
3 participants