Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR-18338.3 #86

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

FR-18338.3 #86

wants to merge 3 commits into from

Conversation

alex-minaiev-frontegg
Copy link
Collaborator

This PR was founded on https://frontegg.atlassian.net/browse/FR-18338 point 3

Created FronteggApp and FronteggAuth interfaces for separation interface and realization and provided to customers only necessary methods and properties to avoid accessing the inner implementation of methods and properties.

New Component:

  1. FronteggAppService - implementation of FronteggApp interface.
  2. FronteggInnerStorage - store all necessary information about SDK running (baseUrl, clientId, applicationId, etc.). Created to avoid using FronteggApp and FronteggAppService by SDK components.
  3. FronteggAuthService - implementation of FronteggAuth interface.
  4. FronteggAppLifecycle - separate object for listening to application Lifecycle Events. Created to encapsulate all data and methods responsible for AppLifecycle (encapsulation Principle of OOP).
  5. FronteggRefreshTokenTimer - separate object for managing RefreshTokenTimer. Created to encapsulate all data and methods responsible for RefreshTokenTimer (encapsulation Principle of OOP).
  6. Renamed RefreshTokenService with RefreshTokenJobService - to avoid confusion with SDK Services.
  7. ReadOnlyObservableValue - using ObservableValue customer could change the value of ObservableValue. ReadOnlyObservableValue lock set ability of value.

@alex-minaiev-frontegg
Copy link
Collaborator Author

@frontegg-david I've added comments to main classes please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant