Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR-14999 - Fixed support for vue-router 4 in vue 3 #398

Merged
merged 7 commits into from
Jan 28, 2024
Merged

FR-14999 - Fixed support for vue-router 4 in vue 3 #398

merged 7 commits into from
Jan 28, 2024

Conversation

frontegg-david
Copy link
Collaborator

No description provided.

doregg
doregg reviewed Jan 24, 2024
View reviewed changes
packages/vue/src/index.ts Outdated Show resolved Hide resolved
frontegg-david and others added 4 commits January 25, 2024 12:12
@frontegg-david @doregg
Update packages/vue/src/auth/mapAuthState.ts
2af411d 
Co-authored-by: Dor Moshe <130984778+doregg@users.noreply.github.com>
@frontegg-david @doregg
Update packages/vue/src/auth/mapAuthState.ts
e68a795 
Co-authored-by: Dor Moshe <130984778+doregg@users.noreply.github.com>
@frontegg-david
replace with defaultFronteggRoutes
847877f
@frontegg-david
combine multiple isAuthRoutes functions
dbd5308
@doregg doregg changed the title FR-14999 - Add fallback support for currentRoute.value.fullPath FR-14999 - Fixed support for vue-router 4 in vue 3 Jan 28, 2024
@doregg doregg merged commit d377b76 into master Jan 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doregg doregg doregg left review comments

@yuvalotem1 yuvalotem1 yuvalotem1 approved these changes

@aviadmizrachi aviadmizrachi Awaiting requested review from aviadmizrachi aviadmizrachi is a code owner

@rotemzif1 rotemzif1 Awaiting requested review from rotemzif1

@amirjaron amirjaron Awaiting requested review from amirjaron amirjaron is a code owner

@MaxArnautFrontegg MaxArnautFrontegg Awaiting requested review from MaxArnautFrontegg MaxArnautFrontegg is a code owner

@TomerFrontegg TomerFrontegg Awaiting requested review from TomerFrontegg TomerFrontegg is a code owner

@mariavlasov mariavlasov Awaiting requested review from mariavlasov mariavlasov is a code owner

@AtaliaRefua AtaliaRefua Awaiting requested review from AtaliaRefua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frontegg-david @yuvalotem1 @doregg