Support multiple declarations in a single statement #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new statement node called `DeclStmtNode` has been introduced to hold multiple declarations. The AST nodes backed by non-terminals that take `decl` now accept a `DeclStmtNode` instead of a `DeclNode`. These nodes include `LoopInitNode` and `CompoundStmtNode`; other nodes remain unaffected. Since `DeclStmtNode` is simply a sequence of `DeclNode`s, the `Visit` functions will visit each `DeclNode` it holds.
Objects are placed in a valid but unspecified state after being moved-from.
Since an item of a compound statement is no longer an `std::variant`, we no longer use a type alias to simplify the type. Additionally, the data member has been renamed to remove the word `item`, which is a technical term used during parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new statement node called
DeclStmtNodehas been introduced to hold multiple declarations. The AST nodes backed by non-terminals that takedeclnow accept aDeclStmtNodeinstead of aDeclNode. These nodes includeLoopInitNodeandCompoundStmtNode; other nodes remain unaffected.Since
DeclStmtNodeis simply a sequence ofDeclNodes, theVisitfunctions will visit eachDeclNodeit holds.How to review?
DeclNode, nearly all *.exp files are affected. However, reviewing decl.c, for_stmt.c, pointer.c, array.c, struct.c, and union.c along with their corresponding *.exp files should suffice.