Support comma operator #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lai-YT
force-pushed
the
feat-comma-operator
branch
from
8b1e00d
to
df7b3af
Compare
This was incorrect precedence, which would break many of the test cases once we introduce the comma operator.
Although comma operator is one of the binary operators, it has its special type checking rules. Thus, a new test case is added.
Lai-YT
force-pushed
the
feat-comma-operator
branch
from
df7b3af
to
2a227ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered adding a new node instead of supporting the comma operator as one of the binary operators, since it requires completely different type checking and code generation compared to other binary operators. This is evident from the ad-hoc rules added to both the type checker and code generator. However, I decided to keep it as a binary operator to align with the fact that it is, indeed, a binary operator, similar to how Clang handles it.
Let me know your thoughts on this approach!