Remove redundant id check on function call #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is redundant because it is already performed by the visit function of `IdExprNode`.
We use abbreviations of AST node types for parameters in the visit function. However, the parameter for `RecordVarDeclNode` violates this convention, which caused confusion and made it seem like I was looking at the visit function for `RecordDeclNode`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed the redundant id check issue mentioned in #163, as whether the id is declared or not is already checked by the visit function of
IdExprNode.Additionally, I renamed a parameter that had confused me. We use abbreviations of AST node types for parameters in the visit function. However, the parameter for
RecordVarDeclNodeviolates this convention, which caused confusion and made it seem like I was looking at the visit function forRecordDeclNode.